Conversation
added 2 commits
March 7, 2026 18:01
…, no redirect following - #27: Add _validate_repo() and _validate_branch() with strict regex allowlists - Repo must match owner/repo pattern with safe chars only - Branch validated against safe character set, rejects '..' traversal - #28: Apply sanitize_skill_name() to every skill directory during 'apc import' - Traversal paths like '../../etc' are safely stripped to their basename - Names failing sanitization are skipped with a warning - #30: Replace follow_redirects=True with follow_redirects=False in httpx calls - Introduced _safe_get() helper in skills.py to centralise this policy - Prevents SSRF via open-redirect chains from GitHub API/raw URLs
forge-fz2000
added a commit
that referenced
this pull request
Mar 9, 2026
… diff Removed incorrectly listed items that are NOT in main: - apc skill remove / apc unsync (PR #72 was merged into a feature branch, not main) - Windsurf/Copilot native sync support (same) - --target/-t removal from apc install (same) Added missing items that ARE in main since v0.1.1: - Security fixes: input validation, chmod 600 MCP configs, scrub secrets from export (#27,#28,#30 via #50; #32,#35 via #52) - Bug fixes: LLM write guard, expanduser paths, Copilot absolute paths (#37,#38-#43,#42 via #53; #36,#45 via #54) - Fix: ~/.apc/skills/ always created after apc install - Fix: --version reads from importlib.metadata - Docs: README shell completion, CLI basics (#23,#26 via #67)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27, Fixes #28, Fixes #30
Added tests/test_security_input_validation.py with 13 tests. All 256 tests pass.