fix: unblock active streams on session close#43
Open
varin-nair-factory wants to merge 1 commit into
Open
Conversation
factory-davidgu
previously approved these changes
May 20, 2026
varin-nair-factory
dismissed
factory-davidgu’s stale review
The base branch was changed.
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
varin-nair-factory
force-pushed
the
vn/close-unblocks-stream
branch
from
9fa95e2 to
070bb09
Compare
factory-davidgu
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
DroidSession.close()so active stream consumers are explicitly released when a session is closed, even if the CLI never emits an idle/result notification.This tracks active message bridges, signals them during close, and races pending
addUserMessagestartup against bridge completion so pending stream startup cannot hang during shutdown.Tests
npm test -- tests/session.test.tsnpm run typechecknpm run lintnpm testnpm run format:checkStacked on #42.