Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"devDependencies": {
"@types/express": "^4.17.21",
"@types/node": "^20.11.0",
"@types/uuid": "^11.0.0",
Comment thread
castlenthesky marked this conversation as resolved.
"@typescript-eslint/eslint-plugin": "^6.15.0",
"@typescript-eslint/parser": "^6.15.0",
"eslint": "^8.56.0",
Expand Down
225 changes: 222 additions & 3 deletions src/controllers/mcp.controller.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Request, Response } from 'express';
import { mcpController } from './mcp.controller';
import { falkorDBService } from '../services/falkordb.service';
import { mcpController } from './mcp.controller';

// Mock the falkorDBService
jest.mock('../services/falkordb.service', () => ({
Expand All @@ -10,6 +10,11 @@ jest.mock('../services/falkordb.service', () => ({
}
}));

// Mock uuid
jest.mock('uuid', () => ({
v4: jest.fn(() => 'test-uuid')
}));

describe('MCP Controller', () => {
let mockRequest: Partial<Request>;
let mockResponse: Partial<Response>;
Expand All @@ -25,7 +30,8 @@ describe('MCP Controller', () => {
mockStatus = jest.fn().mockReturnThis();
mockResponse = {
json: mockJson,
status: mockStatus
status: mockStatus,
header: jest.fn().mockReturnThis()
};
});

Expand Down Expand Up @@ -70,7 +76,7 @@ describe('MCP Controller', () => {

test('should execute query and return results', async () => {
// Arrange
const mockQueryResult = { records: [{ id: 1, name: 'test' }] };
const mockQueryResult = { data: [{ id: 1, name: 'test' }], metadata: {} };
(falkorDBService.executeQuery as jest.Mock).mockResolvedValue(mockQueryResult);

mockRequest = {
Expand Down Expand Up @@ -129,4 +135,217 @@ describe('MCP Controller', () => {
}));
});
});

describe('initialize', () => {
test('should return 400 if jsonrpc version is invalid', async () => {
mockRequest = {
body: {
jsonrpc: '1.0',
id: 1,
method: 'initialize'
}
};

await mcpController.initialize(mockRequest as Request, mockResponse as Response);

expect(mockStatus).toHaveBeenCalledWith(400);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
error: expect.objectContaining({
code: -32600
})
}));
});

test('should initialize session successfully', async () => {
mockRequest = {
body: {
jsonrpc: '2.0',
id: 1,
method: 'initialize'
}
};

await mcpController.initialize(mockRequest as Request, mockResponse as Response);

expect(mockResponse.header).toHaveBeenCalledWith('Mcp-Session-Id', expect.any(String));
expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({
serverInfo: expect.objectContaining({
name: 'FalkorDB MCP Server'
})
})
}));
});
});

describe('processMetadataRequest', () => {
test('should return metadata', async () => {
await mcpController.processMetadataRequest(mockRequest as Request, mockResponse as Response);

expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
provider: 'FalkorDB MCP Server',
capabilities: expect.any(Array)
}));
});
});
Comment on lines +182 to +192
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

mockRequest is uninitialized — passing undefined to the controller.

mockRequest is declared on Line 19 but never assigned in beforeEach, and this test doesn't set it either. If processMetadataRequest accesses any property on req, this will throw a TypeError at runtime. Even if the current implementation ignores the request, this is fragile.

Proposed fix
   describe('processMetadataRequest', () => {
     test('should return metadata', async () => {
+      mockRequest = {};
       await mcpController.processMetadataRequest(mockRequest as Request, mockResponse as Response);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
describe('processMetadataRequest', () => {
test('should return metadata', async () => {
await mcpController.processMetadataRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
provider: 'FalkorDB MCP Server',
capabilities: expect.any(Array)
}));
});
});
describe('processMetadataRequest', () => {
test('should return metadata', async () => {
mockRequest = {};
await mcpController.processMetadataRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
provider: 'FalkorDB MCP Server',
capabilities: expect.any(Array)
}));
});
});
🤖 Prompt for AI Agents
In `@src/controllers/mcp.controller.test.ts` around lines 182 - 192, The test
passes an uninitialized mockRequest to mcpController.processMetadataRequest
which can cause a TypeError; initialize mockRequest in the test setup
(beforeEach) to a minimal Request-like object (e.g., an empty object cast to
Request or an object with any properties the controller reads) and use that
initialized mockRequest when calling processMetadataRequest; update the
beforeEach or the specific test to assign mockRequest so processMetadataRequest
receives a defined Request and the mocks (mockResponse, mockStatus, mockJson)
continue to be asserted.


describe('handleRpcRequest', () => {
test('should delegate initialize', async () => {
mockRequest = { body: { method: 'initialize', jsonrpc: '2.0', id: 1 } };
const spy = jest.spyOn(mcpController, 'initialize');
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(spy).toHaveBeenCalled();
});

test('should handle notifications/initialized', async () => {
mockRequest = { body: { method: 'notifications/initialized', jsonrpc: '2.0' } };
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({ result: true }));
});

test('should handle ping', async () => {
mockRequest = { body: { method: 'ping', jsonrpc: '2.0', id: 1 } };
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({ result: {} }));
});

test('should handle tools/list', async () => {
mockRequest = { body: { method: 'tools/list', jsonrpc: '2.0', id: 1 } };
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({ tools: expect.any(Array) })
}));
});

test('should handle resources/list', async () => {
mockRequest = { body: { method: 'resources/list', jsonrpc: '2.0', id: 1 } };
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
});

test('should handle prompts/list', async () => {
mockRequest = { body: { method: 'prompts/list', jsonrpc: '2.0', id: 1 } };
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200);
});

test('should return error for unknown method', async () => {
mockRequest = { body: { method: 'unknown', jsonrpc: '2.0', id: 1 } };
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockStatus).toHaveBeenCalledWith(200); // It returns 200 with error body
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
error: expect.objectContaining({ code: -32601 })
}));
});

describe('tools/call', () => {
test('should return error if tool not found', async () => {
mockRequest = {
body: {
method: 'tools/call',
jsonrpc: '2.0',
id: 1,
params: { name: 'unknown_tool', arguments: {} }
}
};
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
error: expect.objectContaining({ code: -32601 })
}));
});

test('graph_query success', async () => {
(falkorDBService.executeQuery as jest.Mock).mockResolvedValue({ data: [{ id: 1 }] });
mockRequest = {
body: {
method: 'tools/call',
jsonrpc: '2.0',
id: 1,
params: { name: 'graph_query', arguments: { graphName: 'g', query: 'match n return n' } }
}
};
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(falkorDBService.executeQuery).toHaveBeenCalledWith('g', 'match n return n', {});
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({ content: expect.any(Array) })
}));
});

test('list_graphs success', async () => {
(falkorDBService.listGraphs as jest.Mock).mockResolvedValue(['g1']);
mockRequest = {
body: {
method: 'tools/call',
jsonrpc: '2.0',
id: 1,
params: { name: 'list_graphs', arguments: {} }
}
};
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(falkorDBService.listGraphs).toHaveBeenCalled();
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({ content: expect.any(Array) })
}));
});

test('get_graph_schema success', async () => {
(falkorDBService.executeQuery as jest.Mock).mockImplementation((graph, query) => {
if (query.includes('labels')) return Promise.resolve({ data: [{ label: 'Person' }] });
if (query.includes('relationshipTypes')) return Promise.resolve({ data: [{ relationshipType: 'KNOWS' }] });
if (query.includes('MATCH')) return Promise.resolve({ data: [] });
return Promise.resolve({ data: [] });
});

mockRequest = {
body: {
method: 'tools/call',
jsonrpc: '2.0',
id: 1,
params: { name: 'get_graph_schema', arguments: { graphName: 'g' } }
}
};
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({ content: expect.any(Array) })
}));
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

test('get_node_properties success', async () => {
(falkorDBService.executeQuery as jest.Mock).mockResolvedValue({ data: [{ props: {} }] });
mockRequest = {
body: {
method: 'tools/call',
jsonrpc: '2.0',
id: 1,
params: { name: 'get_node_properties', arguments: { graphName: 'g', label: 'L' } }
}
};
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({ content: expect.any(Array) })
}));
});

test('get_relationship_properties success', async () => {
(falkorDBService.executeQuery as jest.Mock).mockResolvedValue({ data: [{ props: {} }] });
mockRequest = {
body: {
method: 'tools/call',
jsonrpc: '2.0',
id: 1,
params: { name: 'get_relationship_properties', arguments: { graphName: 'g', relationshipType: 'R' } }
}
};
await mcpController.handleRpcRequest(mockRequest as Request, mockResponse as Response);
expect(mockJson).toHaveBeenCalledWith(expect.objectContaining({
result: expect.objectContaining({ content: expect.any(Array) })
}));
});
});
});
});
Loading