[Avro] Basic logicalType support for date time types - #278
Conversation
|
I assume you would like this for 2.x? If so, this needs to be rebased against 2.13 branch; |
|
Yes, for 2.x please. I will rebase it. |
|
@cowtowncoder I have rebased it onto |
|
Sorry, I read your comment too quickly.
|
|
Ok thanks! This seems like relatively safe change, but use of |
|
Sure, 2.13 it fine. BTW: There is a failing test in 2.13. I cannot find cause quickly - there is no change in Avro module between 2.12 and 2.13 obviously realted to the error: |
|
@MichalFoksa yes, I noticed that odd new failure just before leaving for vacation but haven't had time to see what gives. Hoping to look at it soon; definitely should not have failures from clean clone. :-( |
|
hey :) look at here #281 - it issue about the problem with attached PR. |
…edDateTime to Avro long type and logicalType.
|
I will open new PR when I am ready. |
|
@MichalFoksa Ok just let me know! I have been bit busy with non-Jackson things for past 2 weeks but will try to get things reviewed and merged. Plus as per https://github.com/FasterXML/jackson/issues/83 now starting to focus on getting RC1 of 2.13.0 out soon -- there is still time for this and other changes but want to make sure I know the state of things. |
|
@cowtowncoder Here you are new PR #283 - I think it is ready for review. |
PR in reference to #277, point 1.
Simple mapping of few Java date-time types to Avro
logicalType. The mapping works if ObjectMapper is used with JavaTimeModule and WRITE_DATE_TIMESTAMPS_AS_NANOSECONDS is disabled. In this combination JSR310 types are mapped to Avro LONG, only the logical type is missing.Supported java types:
java.util.Datejava.time.OffsetDateTimejava.time.ZonedDateTimejava.time.Instantjava.time.LocalDatejava.time.LocalTimejava.time.LocalDateTime