V2: Actor implementation for "Trader" (WIP)#4
Merged
Conversation
FergusInLondon
changed the title
FergusInLondon
force-pushed
the
v2/trader-actor
branch
2 times, most recently
from
16daa72 to
3daafcc
Compare
This PR introduces a WIP implementation of the `SyncAgent`, an Actor-based component that is responsible for handling messages from both the strategy and the exchange. Inbound data from the exchange - via the user stream - is used to maintain a snapshot of the status of the account. Whilst messages originating from the strategy are used to generate transactions destined for the exchange. The SyncAgent runs within the context of it's own thread, and communication is managed via a Queue and associated message types. There are associated tests for the SyncAgent, written in Gherkin and using the `behave` python package. Incidental Work: - All changes to the `AccountStatus` entity are now done via combined update/mutation objects, available in the `mutations` module. - Trader/Account and Strategy entities are now combined, this allows more customisation when writing strategies, but also removes some moving parts. - User defined `Strategy` objects are now expected to implement any risk calculations - as opposed to having seperate `Calculator` objects. - The Runner is now capable of handling graceful shutdowns, and terminating the SyncAgent and API Adapter. - Unit test coverage has improved, although the BDD tests need work for compatibility with the new `SyncAgent` - Various amendments and tweaks to interface/abstract classes. - The `Makefile` now has a 'help' target. As usual, these changes are driven by the living design document on notion.so
FergusInLondon
force-pushed
the
v2/trader-actor
branch
from
3daafcc to
18eceb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.