fix: capture full error cause stacks#444
Merged
Merged
Conversation
Synapse in particular uses wrapped errors with cause and they are being missed
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates backend structured error logging to include nested Error.cause chains so wrapped errors (notably from Synapse) retain their underlying failure context in logs.
Changes:
- Extend
StructuredErrorwith an optionalcausefield and recursively serializeError.cause. - Add a recursion depth cap (
MAX_CAUSE_DEPTH) to avoid unbounded nesting. - Add unit tests covering cause chain serialization and depth limiting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/backend/src/common/logging.ts | Adds recursive cause serialization to structured errors with a max depth limit. |
| apps/backend/src/common/logging.spec.ts | Adds tests validating cause chain serialization and recursion depth limiting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjan90
approved these changes
Apr 10, 2026
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
SgtPooki
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synapse in particular uses wrapped errors with cause and they are being missed