chore: updated defaults for config.rs #78
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the default pinned upstream revisions in Config::default() to newer Lotus/Curio/filecoin-services versions, keeping devnet startup reproducible via Git tags/commits.
Changes:
- Bump default Lotus version from
v1.34.4-rc1tov1.35.0. - Update default pinned Git commits for Curio and filecoin-services.
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
sure .. I don't know what we have in filecoin-services HEAD that could be a problem, but 🤞 the other two are good
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
Will wait for CI to pass, if it passes, we can say the start is passing, which is done criteria for now. Can calibrate later. |
BigLep
left a comment
BigLep
left a comment
There was a problem hiding this comment.
I think it would be nice to use tags if possible for being able to quickly reason about what's running with visual inspection.
Although I guess we're probably hitting an issue of new tags haven't been issued for a bit.
| curio: Location::GitCommit { | ||
| url: "https://github.com/filecoin-project/curio.git".to_string(), | ||
| commit: "4d53c8017ad345410adfd80794fd7518b49c9128".to_string(), | ||
| commit: "60f77a618eee24cd3482be5fea545e01f26052a4".to_string(), |
There was a problem hiding this comment.
Maybe easier to reason about / spot check if we tie to a tag: https://github.com/filecoin-project/curio/tree/pdp/v1.2.0 ?
(I'm sure @rjan90 can cut a more recent tag if we want.)
| filecoin_services: Location::GitCommit { | ||
| url: "https://github.com/FilOzone/filecoin-services.git".to_string(), | ||
| commit: "2b247916ddd33e4112dc69fd3ea4fc88a3976f56".to_string(), | ||
| commit: "c79e2c6b37372e9b381d3e2b79e787dc132195dc".to_string(), |
There was a problem hiding this comment.
Same here: ok to use a tag https://github.com/FilOzone/filecoin-services/tree/v1.1.0 ?
Updated the default dependencies to latest known today