-
Notifications
You must be signed in to change notification settings - Fork 4
chore: enable cargo test in CI #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,15 +21,6 @@ use crate::run_id::load_current_run_id; | |
| /// This function displays the status of all expected foc-devnet services, | ||
| /// including Docker containers, their uptime, and port accessibility. | ||
| /// If a run ID exists, it shows the actual container names with run ID prefix. | ||
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ```rust,no_run | ||
| /// use foc_devnet::commands::status::running_status::print_running_status; | ||
| /// | ||
| /// print_running_status().expect("Failed to print running status"); | ||
| /// ``` | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns an error if Docker commands fail. | ||
|
|
@@ -188,15 +179,15 @@ mod tests { | |
| #[test] | ||
| fn test_extract_base_image_name() { | ||
| assert_eq!( | ||
| extract_base_image_name("foc-26jan02-1058_TizzyTike-lotus"), | ||
| extract_base_image_name("foc-20251215T2206_ZanyPip-lotus"), | ||
| crate::constants::LOTUS_CONTAINER | ||
| ); | ||
| assert_eq!( | ||
| extract_base_image_name("foc-26jan02-1058_TizzyTike-lotus-miner"), | ||
| extract_base_image_name("foc-20251215T2206_ZanyPip-lotus-miner"), | ||
| crate::constants::LOTUS_MINER_CONTAINER | ||
| ); | ||
| assert_eq!( | ||
| extract_base_image_name("foc-26jan02-1058_TizzyTike-curio-1"), | ||
| extract_base_image_name("foc-20251215T2206_ZanyPip-curio-1"), | ||
| crate::constants::CURIO_CONTAINER | ||
| ); | ||
|
Comment on lines
180
to
192
|
||
| assert_eq!( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,12 +32,12 @@ pub const REQUIRED_DOCKER_IMAGES: &[&str] = &[ | |
| ]; | ||
|
|
||
| /// Docker container names (base - will be prefixed with foc-c-<RUN_ID>- in practice) | ||
| pub const LOTUS_CONTAINER: &str = "foc-c-lotus"; | ||
| pub const LOTUS_MINER_CONTAINER: &str = "foc-c-lotus-miner"; | ||
| pub const BUILDER_CONTAINER: &str = "foc-c-builder"; | ||
| pub const YUGABYTE_CONTAINER: &str = "foc-c-yugabyte"; | ||
| pub const CURIO_CONTAINER: &str = "foc-c-curio"; | ||
| pub const PORTAINER_CONTAINER: &str = "foc-c-portainer"; | ||
| pub const LOTUS_CONTAINER: &str = "foc-lotus"; | ||
| pub const LOTUS_MINER_CONTAINER: &str = "foc-lotus-miner"; | ||
| pub const BUILDER_CONTAINER: &str = "foc-builder"; | ||
| pub const YUGABYTE_CONTAINER: &str = "foc-yugabyte"; | ||
| pub const CURIO_CONTAINER: &str = "foc-curio"; | ||
| pub const PORTAINER_CONTAINER: &str = "foc-portainer"; | ||
|
Comment on lines
34
to
+40
|
||
|
|
||
| /// Port numbers | ||
| pub const LOTUS_RPC_PORT: u16 = 1234; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
cargo testinvocation will also run doctests; the repo currently has at least one runnable doctest insrc/commands/status/mod.rs(module-level "Usage" example) that callsstatus::status()and will fail on a clean CI environment (requires an initialized config). Either mark that doctest asno_run/ignore(preferred) or adjust CI to avoid running doctests until the docs are fixed, otherwise this job is likely to be flaky/fail consistently.