docs: note withCDN option in getting started docs#440
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | d7272de | Commit Preview URL Branch Preview URL |
Dec 03 2025, 07:04 PM |
| // Uncomment to supercharge retrievability with Filecoin Beam | ||
| // withCDN: true |
There was a problem hiding this comment.
Lets ignore the PR then
There was a problem hiding this comment.
This seems not to be true:
There was a problem hiding this comment.
why ? the second line makes it true no ?
There was a problem hiding this comment.
The second line checks if it's true? 🤔
There was a problem hiding this comment.
Lol your are right wth is that
There was a problem hiding this comment.
It just sets the argument to true if it's exaclty true, otherwise it sets it to false. So we're not doing a truthy check, only a strict true check. I don't know why it's like this though.
Anyway, this means that withCDN is off by default, and we can reopen this PR I think
rvagg
changed the title
|
I'm fine with this (wording could be more nuanced, but also whatever); was your close an objection @hugomrdias ? |
|
No, we reopened afterwards because of this #440 (comment) i thought it was already enabled by default because of this but it isn't.Im good with merging but we probably should remove that |
|
We can update the wording. I agree it isn't the best. |
|
Wording updated |
Co-authored-by: patrickwoodhead <patrick.woodhead@protocol.ai> Co-authored-by: Rod Vagg <rod@vagg.org>
4 participants
Adding a reference to Filecoin Beam in the Synapse getting started guide.