feat: add support for ledger#478
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | d27ab5a | Commit Preview URL Branch Preview URL |
Dec 10 2025, 02:53 PM |
hugomrdias
force-pushed
the
hugomrdias/ledger
branch
from
c2ff06d to
281b6f7
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
rjan90
reviewed
Dec 4, 2025
rjan90
reviewed
Dec 4, 2025
rjan90
reviewed
Dec 4, 2025
rjan90
reviewed
Dec 4, 2025
rvagg
reviewed
Dec 4, 2025
rjan90
reviewed
Dec 4, 2025
rjan90
reviewed
Dec 4, 2025
rjan90
approved these changes
Dec 4, 2025
Collaborator
rjan90
left a comment
rjan90
left a comment
There was a problem hiding this comment.
Changes looks okay to me. One outstanding comment from Rod that would be worth aligning on before merging
rvagg
reviewed
Dec 5, 2025
- Introduced a new `ledger.ts` file for Ledger device integration, including functions for account management and transaction signing. - Updated `package.json` to include new dependencies for Ledger support and adjusted existing dependencies to their latest versions. - Added type definitions for Ledger transport and account parameters.
- Added type definitions and support for `filsnap` and `ledger` in `package.json`. - Updated `filsnap.ts` to include a check for connector compatibility. - Introduced a new `ledger.ts` file for comprehensive Ledger device integration, including account management and transaction signing. - Updated dependencies in `package.json` to their latest versions, including `@biomejs/biome` and `wagmi`.
- Bumped versions of several dependencies in `package.json`, including `ox`, `viem`, `@biomejs/biome`, `abitype`, and `iso-web` to their latest releases.
- Bumped versions of `@biomejs/biome` to 2.3.8 and `knip` to 5.70.2.
…ntDialog - Changed the validation message to clarify that the Address Index must be equal to or greater than 0.
…rectly handled - Updated the `changeAccount` function to destructure parameters for better clarity and maintainability. - Moved the device removal logic to ensure it executes after the device is found, improving the flow of the function.
- Renamed `domainSeperator` to `domainSeparator` for consistency and clarity in the `ledgerToAccount` function. - Updated the corresponding usage in the signing process to reflect the corrected variable name.
…edgerChangeAccountDialog - Updated the form schema and submission function to reflect the change in context from withdrawal to account change, enhancing clarity and maintainability.
- Deleted outdated dependencies related to Ledger integration, including `@ledgerhq/hw-app-eth`, `@ledgerhq/hw-transport`, `@ledgerhq/hw-transport-webhid`, and `@wagmi/core`, to streamline the package and reduce bloat.
hugomrdias
force-pushed
the
hugomrdias/ledger
branch
from
f9a8c4b to
43a9b50
Compare
This was referenced Dec 10, 2025
lordshashank
pushed a commit
to lordshashank/synapse-sdk
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase Merge please