Skip to content

fix: support multi sp upload flow in react and demo#675

Merged
hugomrdias merged 7 commits into
masterfrom
hugomrdias/646
Mar 17, 2026
Merged

fix: support multi sp upload flow in react and demo#675
hugomrdias merged 7 commits into
masterfrom
hugomrdias/646

Conversation

@hugomrdias
Copy link
Copy Markdown
Member

@hugomrdias hugomrdias commented Mar 17, 2026

closes #646

@hugomrdias hugomrdias requested a review from rvagg as a code owner March 17, 2026 11:49
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Mar 17, 2026
@hugomrdias hugomrdias requested a review from juliangruber March 17, 2026 11:49
@hugomrdias hugomrdias self-assigned this Mar 17, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 17, 2026

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 17, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
synapse-dev 230d5be Commit Preview URL

Branch Preview URL
Mar 17 2026, 01:16 PM

Copy link
Copy Markdown
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload fails for me, while it passes on #master.

Error:

StoreError: Failed to store on primary provider 9 (https://calib.ezpdpz.net/)

Details: StorageContext store failed: Failed to store piece on service provider - Failed to upload piece.

Details: Service Provider PDP
Failed to upload piece: Failed to finalize commP calculation
    SynapseError base.ts:38
    StoreError storage.ts:18
    upload manager.ts:199
Caused by: Error: StorageContext store failed: Failed to store piece on service provider - Failed to upload piece.

Details: Service Provider PDP
Failed to upload piece: Failed to finalize commP calculation
    createError errors.ts:13
    store context.ts:683
Caused by: UploadPieceError: Failed to upload piece.

Details: Service Provider PDP
Failed to upload piece: Failed to finalize commP calculation
    SynapseError base.ts:38
    UploadPieceError pdp.ts:95
    uploadPieceStreaming sp.ts:382
Caused by: undefined

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ⌨️ In Progress in FOC Mar 17, 2026
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not being exported anywhere

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i just dont want to delete yet, in the case we go back to straight upload with multiple files support.

}

function onSubmit(e: React.FormEvent<HTMLFormElement>) {
function onSubmit(e: React.SubmitEvent<HTMLFormElement>) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FOC Mar 17, 2026
@juliangruber
Copy link
Copy Markdown
Member

Bug discovered: #678
Hugo requested to file an issue so this can be solved later

@hugomrdias hugomrdias merged commit 7f70914 into master Mar 17, 2026
15 checks passed
@hugomrdias hugomrdias deleted the hugomrdias/646 branch March 17, 2026 13:59
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Update synapse-react to support multi sp upload flow

2 participants