Open
Conversation
rowanmanning
force-pushed
the
tests-for-node-test
branch
from
c01a041 to
0cbc549
Compare
rowanmanning
force-pushed
the
tests-for-node-test
branch
2 times, most recently
from
2152d4d to
cb7652e
Compare
This caused an interesting issue with writing tests for this plugin, it's fine if the `cwd` is _actually_ the `cwd` because `glob` returns file paths relative to that. However, in the tests when we're overriding the `cwd` to access fixture files, the relative paths don't work because it assumes the files are relative to wherever Jest is running from. Anyway it shouldn't impact anyone running this normally, just blocks me from writing tests.
This adds in some very basic tests for the node-test plugin, I'd like to build up this test suite so I can think about switching to running tests via the command-line interface - this is required if we want to work with Node.js native test coverage and module mocks.
rowanmanning
force-pushed
the
tests-for-node-test
branch
from
cb7652e to
f7ef6c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds in some very basic tests for the node-test plugin, I'd like to build up this test suite so I can think about switching to running tests via the command-line interface - this is required if we want to work with Node.js native test coverage and module mocks.
Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too