Use a ConcurrentDictionary to remember which calls did work#1147
Merged
cincuranet merged 3 commits intoFirebirdSQL:masterfrom Jul 11, 2024
Merged
Use a ConcurrentDictionary to remember which calls did work#1147cincuranet merged 3 commits intoFirebirdSQL:masterfrom
cincuranet merged 3 commits intoFirebirdSQL:masterfrom
Conversation
This is needed to avoid unnecessary EntryPointNotFoundException exceptions, as they massively slow down program execution - especially in development environments.
Contributor
Author
|
It was a deliberate decision to not remember the action as successful or failed when an exception other than |
cincuranet
requested changes
Mar 15, 2024
src/FirebirdSql.Data.FirebirdClient/Client/Native/FesStatement.cs
Outdated
Show resolved
Hide resolved
Using nameof(IFBClient.xyz), and StringComparer.Ordinal.
Contributor
Author
|
Hi, thank you for your review. I made the two requested changes. |
Contributor
Author
|
@cincuranet Hi, I made the requested changes. Are there any other open points with this PR? |
cincuranet
reviewed
Jul 11, 2024
Member
cincuranet
left a comment
cincuranet
left a comment
There was a problem hiding this comment.
Sorry for late reply. Few nits here and there, after that it should be ready to merge.
src/FirebirdSql.Data.FirebirdClient/Client/Native/FbClientFactory.cs
Outdated
Show resolved
Hide resolved
src/FirebirdSql.Data.FirebirdClient/Client/Native/FesStatement.cs
Outdated
Show resolved
Hide resolved
src/FirebirdSql.Data.FirebirdClient/Client/Native/FesStatement.cs
Outdated
Show resolved
Hide resolved
- No line breaks before arguments - No whitespace between cast operator and casted value
Contributor
Author
|
@cincuranet Hi, I made all requested style fixes. Thank you for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to avoid unnecessary EntryPointNotFoundException exceptions, as they massively slow down program execution - especially in development environments.
Fixes #1146