[codex] Fix Windows workspace change path assertion#1117
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds cross-platform path handling to the artifact workflow test by normalizing path separators before asserting on CLI output, and includes a changeset file documenting the fix. ChangesCross-Platform Path Normalization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
Looks good. The normalizePaths() assertion is the right cross-platform fix, and checks are green.
Summary
Root cause
The previous fix removed the command failure, but this test still hard-coded a Unix-style path. On Windows PowerShell the CLI prints the workspace-relative path as
changes\cross-repo-login/, so the main-branch Windows matrix failed even though the command succeeded.Validation
pnpm exec vitest run test/commands/artifact-workflow.test.ts -t "creates workspace-planning changes under the workspace root without touching linked repos"pnpm exec vitest run test/commands/artifact-workflow.test.tspnpm exec changeset status --since=origin/maingit diff --checkSummary by CodeRabbit