feat: add Oh My Pi (OMP) tool support#1276
Open
xianzheTM wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughWalkthroughAdds Oh My Pi ( ChangesOh My Pi Tool Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
test/core/command-generation/adapters.test.ts (1)
22-22: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueImport is out of alphabetical order.
ohMyPiAdaptershould be imported beforeopencodeAdapterto maintain alphabetical ordering (oh<op). Move this import to betweenkilocodeAdapter(line 20) andopencodeAdapter(line 21).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/core/command-generation/adapters.test.ts` at line 22, The import order in the adapter test setup is not alphabetical. Reorder the imports in adapters.test.ts so that ohMyPiAdapter is placed before opencodeAdapter, keeping it between kilocodeAdapter and opencodeAdapter and preserving the existing alphabetical sequence among the adapter imports.openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md (1)
6-6: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRedundant phrasing: "follows after"
"follows after" is redundant; use "follows" or "comes after". Also, this sentence is very long and hard to parse. Consider breaking it into shorter sentences for clarity.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md` at line 6, The spec wording in the command-body requirements is too verbose and includes redundant phrasing; update the text in the Oh My Pi tool spec to use simpler language, replacing “follows after” with “follows” or “comes after” and splitting the long sentence into shorter, clearer sentences. Keep the same requirements in the spec entry that mentions the YAML frontmatter, `/opsx:` to `/opsx-` transformation, and `**Provided arguments**: $@` injection, but rewrite that description for readability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md`:
- Line 6: The spec wording in the command-body requirements is too verbose and
includes redundant phrasing; update the text in the Oh My Pi tool spec to use
simpler language, replacing “follows after” with “follows” or “comes after” and
splitting the long sentence into shorter, clearer sentences. Keep the same
requirements in the spec entry that mentions the YAML frontmatter, `/opsx:` to
`/opsx-` transformation, and `**Provided arguments**: $@` injection, but rewrite
that description for readability.
In `@test/core/command-generation/adapters.test.ts`:
- Line 22: The import order in the adapter test setup is not alphabetical.
Reorder the imports in adapters.test.ts so that ohMyPiAdapter is placed before
opencodeAdapter, keeping it between kilocodeAdapter and opencodeAdapter and
preserving the existing alphabetical sequence among the adapter imports.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 859e2f0a-1a3f-42c2-ae7b-90b3407f037c
📒 Files selected for processing (15)
docs/supported-tools.mdopenspec/changes/feat-add-omp-tool-support/.openspec.yamlopenspec/changes/feat-add-omp-tool-support/design.mdopenspec/changes/feat-add-omp-tool-support/proposal.mdopenspec/changes/feat-add-omp-tool-support/specs/cli-init/spec.mdopenspec/changes/feat-add-omp-tool-support/specs/cli-update/spec.mdopenspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.mdopenspec/changes/feat-add-omp-tool-support/tasks.mdsrc/core/command-generation/adapters/index.tssrc/core/command-generation/adapters/oh-my-pi.tssrc/core/command-generation/registry.tssrc/core/config.tssrc/core/init.tssrc/core/update.tstest/core/command-generation/adapters.test.ts
Add ToolCommandAdapter for Oh My Pi terminal AI coding agent. - New adapter: src/core/command-generation/adapters/oh-my-pi.ts - Commands: .omp/commands/opsx-<id>.md with description frontmatter - Hyphen transform: /opsx: -> /opsx- (filename = command name) - Argument injection: **Provided arguments**: $@ after **Input**: heading - escapeYamlValue applied to description field - Register in CommandAdapterRegistry and adapters/index.ts - Add oh-my-pi to AI_TOOLS with skillsDir: '.omp' - Add to hyphen command transformer whitelist in init.ts and update.ts - Full test coverage (10 cases) in adapters.test.ts - Update docs/supported-tools.md with directory reference and tool ID Closes Fission-AI#713
- Move ohMyPiAdapter import before opencodeAdapter (alphabetical order) - Break long SHALL sentence and remove redundant 'follows after' in spec
alfred-openspec
approved these changes
Jun 29, 2026
alfred-openspec
left a comment
alfred-openspec
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I verified the OMP docs match the core assumptions: project commands live under .omp/commands/*.md, filename stem becomes the slash command, YAML description is valid, and $@ / $ARGUMENTS are supported for arguments.
The adapter follows the existing command-generation pattern, registers cleanly, applies hyphen command references in init/update/legacy upgrade, and has focused tests for path, YAML escaping, reference transform, and argument injection.
Verified locally: pnpm exec vitest run test/core/command-generation/adapters.test.ts passes, 103 tests.
Author
|
@TabishB Hi maintainers, this PR has passed automated checks. Could someone take a look when you have a chance? I'm happy to make any changes if needed. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ToolCommandAdapter for Oh My Pi terminal AI coding agent.
Closes #713
Summary by CodeRabbit
oh-my-pi), including auto-detection during setup and correct generation during updates.