feat(nix): install completions#947
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Builder as Builder (nix build)
participant Host as Host Platform
participant Openspec as `${out}/bin/openspec`
participant Shells as Shell completion dirs
Builder->>Host: Check canRun (buildPlatform == hostPlatform)
alt can run on host
Builder->>Host: export OPENSPEC_TELEMETRY=0
Host->>Openspec: run "openspec --completion bash/fish/zsh"
Openspec-->>Shells: write completion files to $out/.../share/{bash,fish,zsh}/completions
Builder->>Shells: install completion files
else cannot run
Builder-->>Builder: skip postInstall completion generation
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d98d602 to
4cad923
Compare
|
@TabishB is there anything missing here? :) |
669f581 to
253838a
Compare
|
it's rather unusual in nixpkgs to make the installation of completions optional. The problem described in #948 is pretty much ruled out in nix/nixos. some additional detail: |
Summary by CodeRabbit
New Features
Chores