Skip to content

feat: added support for JUnit Theory tests#1968

Merged
mergify[bot] merged 4 commits into
Flank:masterfrom
asadsalman:asalman/theory-support
May 26, 2021
Merged

feat: added support for JUnit Theory tests#1968
mergify[bot] merged 4 commits into
Flank:masterfrom
asadsalman:asalman/theory-support

Conversation

@asadsalman
Copy link
Copy Markdown
Contributor

@asadsalman asadsalman commented May 25, 2021

JUnit Theories were not parsed by Flank perviously. This PR adds support for them.

Test Plan

How do we know the code works?
Added test.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Copy Markdown
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just small change request 👍🏻

Comment thread test_runner/src/main/kotlin/ftl/run/platform/android/CreateAndroidTestContext.kt Outdated
@pawelpasterz
Copy link
Copy Markdown
Contributor

Follow-up: create IT for this case
cc: @axelzuziak-gogo

@Sloox
Copy link
Copy Markdown
Contributor

Sloox commented May 26, 2021

@flank-it

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/6z2jwlakbozqw
Linux Build scan: https://gradle.com/s/uvoga42r32kie
Workflow run https://github.com/Flank/flank/actions/runs/878248758

@bootstraponline bootstraponline force-pushed the asalman/theory-support branch from b25a402 to 74dd6a1 Compare May 26, 2021 11:37
@bootstraponline bootstraponline force-pushed the asalman/theory-support branch from 74dd6a1 to 41163ca Compare May 26, 2021 14:21
@mergify mergify Bot merged commit 4b5b92e into Flank:master May 26, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants