feat: Load test cases durations from previous run and use for sharding#1998
Merged
Conversation
jan-goral
changed the title
jan-goral
force-pushed
the
1988_Reuse_tests_duration_for_sharding
branch
from
40aa407 to
b498afb
Compare
Contributor
|
Timestamp: 2021-06-02 10:06:57 |
adamfilipow92
approved these changes
Jun 2, 2021
Sloox
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1988
Test Plan
flank corellium test android run -c="./test_configs/flank-corellium.yml"several times.android-shards.jsonhave durations different than the default (120)Drawbacks
The first test case in a suite always has a duration increased by initialization overhead. This is a
am instrumentcommand behavior, that not depends on flank implementation. As result, the sharding calculations can be more imprecise for cases with a small number of quick test cases with duration less than initialization overhead.A possible solution could be evaluating overhead time based on previous JUnit results, and taking them into account in sharding calculations.
Checklist