feat: Support HTTP proxies with credentials.#2176
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Title does not follow the guidelines of Conventional Commits.
|
1 similar comment
|
Title does not follow the guidelines of Conventional Commits.
|
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for the contribution! Please add a FAQ entry to https://github.com/Flank/flank/blob/master/docs/index.md that explains how to run Flank with a proxy. After that I'll merge. The code looks good. |
|
I found the command in the linked issue. The snapshot jar will auto update once the build passes on master. I'll make a new stable release next week. |
|
https://github.com/Flank/flank/releases/tag/flank-snapshot has been updated with the feature. |
|
@jdm-square stable release has been published. https://github.com/Flank/flank/releases/tag/v21.11.0 |
Fixes #2175. The addition of the Jboss logging dependency is required to avoid a missing class exception when the HTTP transport is created; it bridges the logback instance to the logging in use inside of the network-related code.
This implementation is based off of the model code in https://github.com/googleapis/google-auth-library-java#configuring-a-proxy.
Test Plan
Following the steps described in #2175, I have validated that flank behaves the same when mitmproxy requires credentials as when it does not.
Checklist