Skip to content

fix: Detect iOS devices as physical#2182

Merged
bootstraponline merged 6 commits into
masterfrom
ios_detect
Nov 12, 2021
Merged

fix: Detect iOS devices as physical#2182
bootstraponline merged 6 commits into
masterfrom
ios_detect

Conversation

@bootstraponline
Copy link
Copy Markdown
Contributor

@bootstraponline bootstraponline commented Nov 11, 2021

Fixes #2179

Test Plan

How do we know the code works?

Ran reduced test case via Debug.kt Verified PHYSICAL used as fallback message does not appear. Checked that the cost calculation is correct.

gcloud:
  test: "./test_runner/src/test/kotlin/ftl/fixtures/tmp/ios/EarlGreyExample/EarlGreyExample.zip"
  xctestrun-file: "./test_runner/src/test/kotlin/ftl/fixtures/tmp/ios/EarlGreyExample/EarlGreyExampleSwiftTests.xctestrun"
  device:
  - model: "iphone11pro"
    version: "14.7"
    locale: "en"
    orientation: "portrait"

CostReport
  Physical devices
    $0.08 for 1m

@bootstraponline bootstraponline mentioned this pull request Nov 11, 2021
Closed
@github-actions github-actions Bot added the Bug label Nov 11, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 12, 2021

Timestamp: 2021-11-12 04:35:43
Buildscan url for ubuntu-workflow run 1451688249
https://gradle.com/s/bcsnnzqiit5ha

@bootstraponline bootstraponline merged commit 3daebd8 into master Nov 12, 2021
@bootstraponline bootstraponline deleted the ios_detect branch November 12, 2021 04:42
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iPhone 11 Pro not recognized as correct device

1 participant

@bootstraponline