Issue #467: iOS support globs for test-targets#478
Merged
Conversation
| @@ -64,11 +64,8 @@ class IosArgs( | |||
| override val testShardChunks: List<List<String>> by lazy { | |||
| val validTestMethods = Xctestrun.findTestNames(xctestrunFile) | |||
Contributor
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
============================================
+ Coverage 78.43% 78.53% +0.09%
- Complexity 666 667 +1
============================================
Files 73 73
Lines 1892 1896 +4
Branches 279 282 +3
============================================
+ Hits 1484 1489 +5
Misses 229 229
+ Partials 179 178 -1 |
bootstraponline
previously approved these changes
Jan 27, 2019
|
Super excited to test it when it's built! |
bootstraponline
previously approved these changes
Jan 27, 2019
Macarse
force-pushed
the
macarse/issue467
branch
from
270ac47 to
8bd9640
Compare
bootstraponline
approved these changes
Jan 27, 2019
|
Worked well! Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467
cc @gtroshin