Fixes #490 Rename testShards to maxTestShards

[miguelslemos]

This PR rename testShards parameter to maxTestShards

Fix #490

[codecov-io]

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is 91.66%.

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage     79.98%   79.98%           
  Complexity      623      623           
=========================================
  Files            73       73           
  Lines          1944     1944           
  Branches        250      250           
=========================================
  Hits           1555     1555           
  Misses          247      247           
  Partials        142      142

[miguelslemos]

This PR is breaking change, should I make it retro compatibility or just bump a major version?

[bootstraponline]

Thanks for the pull request! I'll take a look at this today.

[bootstraponline]

The code looks great.

To make it easy for people to upgrade, I'd like to dynamically rewrite the flank.yml file. If we don't have an auto-migration strategy then this will break immediately after merging since they run from the snapshot.

What do you think of that approach? I can add the code for this if the scope is too large.

The idea would be to read in the input YAML (flank.yml or flank.ios.yml), detect any old keys (such as testShards), and then rename those keys. After the file is rewritten to disk then Flank would proceed normally. We'd want to preserve comments in the YAML file if they exist (and only modify key names).

[bootstraponline]

I talked with the team and once #515 is figured out then I'll merge this pull request. It's an open question how to best preserve backwards compatibility.