Disable FAIL_ON_UNKNOWN_PROPERTIES for forward compatibility#599
Merged
bootstraponline merged 5 commits intoSep 11, 2019
Merged
Disable FAIL_ON_UNKNOWN_PROPERTIES for forward compatibility#599bootstraponline merged 5 commits into
bootstraponline merged 5 commits into
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
============================================
+ Coverage 76.7% 76.75% +0.05%
Complexity 610 610
============================================
Files 81 81
Lines 2262 2263 +1
Branches 324 324
============================================
+ Hits 1735 1737 +2
Misses 308 308
+ Partials 219 218 -1 |
Contributor
|
Thanks for the pull request! Please add a JUnit test that verifies no exception is thrown when an unknown XML property is present in the parsed XML. Something like this, note the addition of val unknownXml= """
<?xml version='1.0' encoding='UTF-8' ?>
<testsuites>
<testsuite random="prop" name="EarlGreyExampleSwiftTests" tests="4" failures="1" errors="0" skipped="0" time="51.773" hostname="localhost">
<testcase name="a()" classname="a" time="1.0" random="prop"/>
</testsuite>
</testsuites>
""".trimIndent()
val parsed= parseAllSuitesXml(unknownXml).xmlToString()
assertThat(parsed).isEqualTo(unknownXml) |
geoff-powell
approved these changes
Sep 11, 2019
Contributor
|
Merged. Thanks for contributing! |
Contributor
|
Release :) ? |
Contributor
|
I'm working on it. The Bitrise GitHub release step is failing. FTL finished the rollback so you shouldn't be broken anymore. |
Contributor
|
yep I see FTL is passing. Thanks ! |
Contributor
|
ping :) |
Contributor
|
I haven't forgotten about this. 🙂 It's on my list. |
|
It just started happening again for us? 🤔 |
Contributor
The Firebase team had a mistake in the rollback. It should be resolved now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that any future additions to the XML by FTL does not break existing builds of flank and is more permissive in structure about deserialization of unknown properties.