Flank should exit with code 1 when validation issues#642
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
============================================
- Coverage 77.59% 77.32% -0.27%
+ Complexity 614 613 -1
============================================
Files 81 82 +1
Lines 2321 2329 +8
Branches 309 311 +2
============================================
Hits 1801 1801
- Misses 325 334 +9
+ Partials 195 194 -1 |
bootstraponline
previously approved these changes
Feb 27, 2020
Contributor
|
I added That will auto close issues once the PRs are merged. |
jan-goral
previously approved these changes
Feb 27, 2020
pawelpasterz
dismissed stale reviews from jan-goral and bootstraponline
via
ba181fb
pawelpasterz
force-pushed
the
flank-doctor-exit-code
branch
from
ba181fb to
2a034a1
Compare
bootstraponline
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448
When validation of yml file fail, process ends with exit code (1).
Prints
Valid yml filemessage otherwise.