#850 fix printing all matrix links#866
Conversation
We want to print only links to failed matrices, not all. The goal is to make it as easy as possible to investigate failures. |
Fixed to print only failures matrices |
bootstraponline
left a comment
bootstraponline
left a comment
There was a problem hiding this comment.
this looks good to me
it would be good to have at least one other member on the team review the PR. 🙂
piotradamczyk5
force-pushed
the
#850-print-all-matrix-links
branch
from
e955693 to
84a5eab
Compare
piotradamczyk5
requested review from
adamfilipow92,
bootstraponline,
jan-goral and
pawelpasterz
| } | ||
| } | ||
|
|
||
| private fun Collection<SavedMatrix>.printMatricesLinks(writer: StringWriter) { |
There was a problem hiding this comment.
Here is my proposal for formatting. I am just not a big fan of multiple ?. chain calls. Of course, it's not change request. Just let me know what do you think
| private fun Collection<SavedMatrix>.printMatricesLinks(writer: StringWriter) { | |
| private fun Collection<SavedMatrix>.printMatricesLinks(writer: StringWriter) = this | |
| .filter { it.failed() } | |
| .takeIf { it.isNotEmpty() } | |
| ?.run { | |
| writer.println("More details are available at:") | |
| forEach { writer.println(it.webLinkWithoutExecutionDetails) } | |
| } |
There was a problem hiding this comment.
I personally preferer to avoid nested operations in block, that's why I changed it to ?. chain (previous version looks like yours :) )
There was a problem hiding this comment.
Got your point. We can still make it simpler and skip one map operation and just invoke forEach { writer.println(it.webLinkWithoutExecutionDetails) }
There was a problem hiding this comment.
applied your suggestion, because of new line comment :)
|
Maybe we could add new line or other separator below links? It's cosmetic change but would improve clarity of logs |
so in that case, you code without |
pawelpasterz
left a comment
pawelpasterz
left a comment
There was a problem hiding this comment.
Nice work, thanks! 👍
3 participants
Fixes #850
Test Plan
All matrices failed links are printed in summary below the summary table.
Do not print any data if there are not present failed links.
Checklist