#835 Added printing available Android software versions#894
Merged
Conversation
91faa32 to
0871747
Compare
| class AndroidVersionsListCommandTest { | ||
|
|
||
| @Test | ||
| fun androidVersionsListCommandOptions() { |
Contributor
There was a problem hiding this comment.
What are the purposes of this test?
Contributor
Author
There was a problem hiding this comment.
checked if parameters are set
Contributor
There was a problem hiding this comment.
There is no logic under the hood. Why do that?
Contributor
Author
There was a problem hiding this comment.
just follow testing practices from other Commands
I will remove it
Contributor
There was a problem hiding this comment.
Yup, I see. Now I found that we should change those practices. There is no reason for testing assignments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #835
Test Plan
Use on of a new CLI option to test this PR:
flank firebase test android versions listorflank android versions list- print Android available versions to test againstSample Android versions list output:
More listing options of the test environment will be added in the next tasks
Checklist