Added preloading configuration and tree parsing + refactor Doctor file#920
Merged
Merged
Conversation
piotradamczyk5
requested review from
adamfilipow92,
bootstraponline,
jan-goral and
pawelpasterz
piotradamczyk5
changed the title
Doctor file
| if (!data.toFile().exists()) return "Skipping yaml validation. No file at path $data" | ||
| return validateYaml(args, loadFile(data)) | ||
| } | ||
| fun validateYaml(args: IArgs.ICompanion, data: Path): String { |
Contributor
There was a problem hiding this comment.
This is the only a proposal
WDYT?
fun validateYaml(args: IArgs.ICompanion, data: Path) =
if (!data.toFile().exists()) "Skipping yaml validation. No file at path $data"
else validateYaml(args, loadFile(data)) + preloadConfiguration(data, args is AndroidArgsCompanion)
Contributor
Author
There was a problem hiding this comment.
Sure, updated 👍
Contributor
|
This is awesome! Great idea to preload the entire config. |
piotradamczyk5
force-pushed
the
#911-added-more-validation-to-doctor
branch
from
9973baa to
5dd7bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911 by adding preloading configuration and tree parsing + refactor
DoctorfileTest Plan
Running command
firebase test android|ios doctororflank android|ios doctorwill show issue when cannot parse.ymlconfiguration (invalid example in root task).Previously doctor validates only basic
.ymlparsing, now it pre-load configuration and validate tree to catch more errorsChecklist