Skip to content

Fix version printing on Flank release #952

Merged
Sloox merged 2 commits into
masterfrom
951-fix-version-printing-flank
Aug 7, 2020
Merged

Fix version printing on Flank release #952
Sloox merged 2 commits into
masterfrom
951-fix-version-printing-flank

Conversation

@Sloox
Copy link
Copy Markdown
Contributor

@Sloox Sloox commented Aug 7, 2020

Fixes #951

Change param runningOnBitrise to more generic runningOnCI

Test Plan

How do we know the code works?
Need to run a build to check the version update.
.

Checklist

  • release_notes.md updated

Copy link
Copy Markdown
Contributor

@piotradamczyk5 piotradamczyk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job

@Sloox Sloox merged commit 8566004 into master Aug 7, 2020
@Sloox Sloox deleted the 951-fix-version-printing-flank branch August 7, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix version printing on Flank release

2 participants