docs: Analytics addition to readme#987
Merged
Merged
Conversation
Sloox
requested review from
adamfilipow92,
bootstraponline,
jan-goral,
pawelpasterz and
piotradamczyk5
bootstraponline
suggested changes
Aug 12, 2020
Contributor
bootstraponline
left a comment
bootstraponline
left a comment
There was a problem hiding this comment.
As an end user, I want to understand what analytics Flank sends and how to control them so I can make good decisions for my business.
The user story asks for:
- What analytics Flank sends
- How to disable them
The current pull request does a great job describing that Flank integrate with bugsnag and how to opt out of analytics. We also want to include detailed information about what specifically Flank sends to bugsnag.
There might be documentation from the bugsnag website that explains what's connected in more detail. Alternatively, we could reference the Flank bugsnag and use that to understand the types of data being collected in crash reports.
Sloox
changed the title
Contributor
|
@Sloox I made a bunch of edits 😁 I think this looks good now! |
pawelpasterz
approved these changes
Aug 13, 2020
piotradamczyk5
approved these changes
Aug 13, 2020
bootstraponline
approved these changes
Aug 13, 2020
pgreze
pushed a commit
to mercari/flank
that referenced
this pull request
Aug 17, 2020
* Added inital analytics template for team review * Added analytics.md file * Re-worked the wording as per discussion * Release notes updated * Fixes to wording, typos and recommendations as per pull request * Update and rename analytics.md to error_monitoring.md * Update README.md * Update error_monitoring.md * Update README.md * Update error_monitoring.md * Update error_monitoring.md * Update release_notes.md * Update README.md Co-authored-by: Michael Wright <michael.wright@gogoapps.io> Co-authored-by: bootstraponline <code@bootstraponline.com>
pgreze
added a commit
to mercari/flank
that referenced
this pull request
Aug 17, 2020
* docs: Analytics addition to readme (Flank#987) * Added inital analytics template for team review * Added analytics.md file * Re-worked the wording as per discussion * Release notes updated * Fixes to wording, typos and recommendations as per pull request * Update and rename analytics.md to error_monitoring.md * Update README.md * Update error_monitoring.md * Update README.md * Update error_monitoring.md * Update error_monitoring.md * Update release_notes.md * Update README.md Co-authored-by: Michael Wright <michael.wright@gogoapps.io> Co-authored-by: bootstraponline <code@bootstraponline.com> * Add filter_qa support in test-targets Co-authored-by: Michael Wright <slooxied@gmail.com> Co-authored-by: Michael Wright <michael.wright@gogoapps.io> Co-authored-by: bootstraponline <code@bootstraponline.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973
Checklist