[Bug] Beacon beam rendering optimizations breaks when using Iris shaders

[terzag]

Make sure you are not opening a duplicate.

• I have searched the issue tracker and did not find an issue describing my crash.

Minecraft version.

1.20.1

Sodium Extra version.

0.4.21

Sodium version.

0.4.10

What happened?

After updating to Sodium Extra 0.4.21, the game freezes just after loading my world. In most cases I then have to kill the process but it sometimes crashes to desktop instead. Got the following error but not every time:

The game crashed whilst rendering block entity
Error: java.lang.IllegalArgumentException: Source format has fewer elements than destination format

Version 0.4.20 works fine. Adding crash report and latest.log related to the error above.

Playing on Linux with an AMD GPU, if that's relevant.

Relevant logs

crash-2023-07-17_11.27.59-client.txt
latest.log

Additional information

No response

[FlashyReese]

Can you try this build sodium-extra-0.4.21+mc1.20.1-unknown.zip?

[terzag]

That one seems to work. Have tried several times to save/reload the game (at different places), no more crash or freeze so far.

[FlashyReese]

Cool I will drop an release

[terzag]

Er... I've just tried 0.4.22 that you uploaded on Modrinth and it still freezes. It even froze once on the "entering world" screen before rendering anything in the game. Haven't had the error message I mentioned with it, though, only freezes.

Reverted to the 0.4.21 "unknown" build that you put above and that one works. So, either the specific bug fix has been skipped in 0.4.22 or the issue is completely random and I've been lucky that the 0.4.21 above works (I've tried several times with both versions, so it's really unlikely).

[FlashyReese]

Using the 0.4.22 build, add mixin.optimizations.beacon_beam_rendering=false to .minecraft/config/sodium-extra.properties. Post a log and let me know if it freezes. It's a bit weird since I'm also running Linux and using the same family GPU as you and I can't replicate your issue.

[terzag]

With that option, it doesn't seem to freeze. And thinking about it, it's quite possible that the freezes happened previously at the exact moment my beacon powered on. Should I try without the option but loading the world outside of the beacon's effect range? or maybe far enough of it to be sure that the beam doesn't render (not sure how far I would need to go)?

Not sure if you need the log given that it doesn't freeze but just in case here is the current latest.log.
latest.log

Tell me if you need a different one and/or if you want a new log + eventual crash file without the option, after the game freezes.

[FlashyReese]

Does the 0.4.21-unknown build freeze when near a beacon beam; without the changes I requested to add in .minecraft/config/sodium-extra.properties?
I'm actually not sure what's going on. It seems like the beacon optimization is not working as intended "but it works fine on my computer"

[terzag]

In all the tests I've made, I was a few blocks away from a beacon. I would need to check if being in the same chunk as the beacon beam has some influence on the freezes but in any case, I would have been at most ~20 blocks from the beacon's beam every time.

• 0.4.20 works (nothing in sodium-extra.properties)
• 0.4.21 initially uploaded to Modrinth −i.e. the one that was there when I opened the bug report− freezes (nothing in sodium-extra.properties)
• 0.4.21 "unknown build" you uploaded above works, no freeze at all (nothing in sodium-extra.properties)
• 0.4.22 from Modrinth freezes with empty sodium-extra.properties but doesn't seem to after adding the option mixin.optimizations.beacon_beam_rendering=false

EDIT: you say that you're on Linux with an AMD GPU too and everything works on your side. A difference between our setups that could lead to a different behavior could be the version of Mesa, maybe? I didn't specify it as it didn't seem important but I use the flatpak version of Minecraft (from FlatHub) and flatpak apps use a special package of Mesa instead of the system one. In my case, it would be 23.1.1 (which is more recent than the system one: 23.0.4 on Xubuntu 23.04).
Or the GPU model? I have a Radeon RX 6500 XT.

Of course, it could also be a conflict with a mod. I didn't mention the ones I use initially given that everything worked fine using Sodium Extra 0.4.20, so I assumed it was more likely that the issue came from a bug in the new version.

[FlashyReese]

I added beacon beam rendering optimizations in >0.4.20 but it doesn't explain why 0.4.21-unknown build fixes it but 0.4.22 is just the same as that except with new version number. Hence why I'm a bit confused.

My mesa driver is 23.1.3 and I have the RX 6600, this optimization commit was a while ago so previous mesa drivers likely worked just fine.

I'm going to revert a patch for some mixin changes I did in 0.4.22 hopefully that wasn't the cause. File below is with the patch reverted.
sodium-extra-0.4.22+mc1.20.1-unknown.zip