Skip to content

Create template form screens#67

Open
geraldyywang wants to merge 5 commits intomainfrom
create-template-form-screens
Open

Create template form screens#67
geraldyywang wants to merge 5 commits intomainfrom
create-template-form-screens

Conversation

@geraldyywang
Copy link
Copy Markdown
Member

@geraldyywang geraldyywang commented Dec 1, 2023 •
edited
Loading

Pull Request

Description

As part of our MVP, we wanted to allow users to fill out forms digitally and submit them. For our MVP, we only care about the Certification of Death form.

Related Issues

Resolves #44

Changes Made

  • Implemented the states and general layout of the 3 forms needed for a life claim
  • Completely finished the CertificationOfDeathForm, needs to be connected to backend in future changes
  • Created a FormQuestion component that groups a form's question and associated text box
  • Created a NewFormScreen to allow embed forms in, can be viewed at /frontend/new-form
  • Any data filled in will be logged to console when form is submitted.
  • NOTE: no error checking is done on the form input fields, nor is it styled.

Screenshots (if applicable)

image

Checklist

  • I have tested the changes locally.
  • My code follows the project's coding style.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.

Additional Notes (if any)

@geraldyywang
gets rid of duplicate justify-center styling
b776f90
@geraldyywang
Implemented state forms for Life Claim Information Request and Life C…
0daa8ae 
…laim Initiation Lender Statement

- For our current workflow, we will not include Certification of Death form
- Instead, we will leave it as something for the user to fill out and upload
@geraldyywang
create CertificationOfDeathForm, started handleSubmit for LifeClaimIn…
66ba7aa 
…formationRequestForm
@geraldyywang
created FormQuestion.js component for question/text inputs in forms
75a40f0
@geraldyywang
Finished CertificationOfDeathForm and embedded in NewFormScreen, adde…
2f6f8d6 
…d to router at /new-form
@Anshiboy
Copy link
Copy Markdown
Contributor

Anshiboy commented Dec 1, 2023

Coding style:
Naming conventions are good, curly braces are all consistent. Good job!

Correctness:
Thoe code runs and does not interfere with any other aspects of the program. As of now it is good, and it looks like it is also synonymous with the backend. One part which may be better is just to reformat the code, but the functionality is there, just a little touch up on aesthetics, as mentioned in the PR.

Presence of tests and Test coverage:
There is no test coverage, however it would be difficult to test until we have a little data, so we can wait.

Clarity of any accompanying information in the pull request:
The PR is very clear , with clear references of pictures where needed showing the specification for certification of death. The details directly correlate to the form information. The PR also explains the changes made and what it accomplishes and doesn't accomplish. Good job!

Overall very nice, just a few tweaks for styling and ensuring tests with new-form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LevOzay LevOzay Awaiting requested review from LevOzay

@GregoryGismondi GregoryGismondi Awaiting requested review from GregoryGismondi

@sarvaSanjay sarvaSanjay Awaiting requested review from sarvaSanjay

@Anshiboy Anshiboy Awaiting requested review from Anshiboy

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add template form screens

2 participants

@geraldyywang @Anshiboy