Fix hyperhemisphere component state assignment - #5260
Open
FlorianPfaff wants to merge 3 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 17:52
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
HyperhemisphereCartProdParticleFilterhad two inconsistent paths for assigning a single hyperhemispherical component distribution to a Cartesian-product particle filter.The
filter_stateproperty setter correctly sampledn_particles * n_hemispherescomponent vectors before reshaping them into the product state. However,set_state(...)bypassed that path and sampled onlyn_particlesvectors, then tried to construct a product distribution from the single-component-width array. For filters with more than one hemisphere this raisesValueError: Dimension is not correct.instead of assigning the distribution across all components.The specialized
filter_statesetter also replaced particle locations without resetting particle weights. That differs from the baseAbstractParticleFilter.filter_statecontract, which resets weights to uniform whenever a new continuous distribution is sampled into the particle state. A prior nonuniform posterior could therefore leak stale weights into a newly sampled state.Fix
set_state(...)assignments through the existing product-awarefilter_statesetter;ones_like(...)for the reset so weight dtype/device are preserved.Regression coverage
Add focused NumPy-backend tests that verify:
set_state(...)expands a singleHyperhemisphericalWatsonDistributionacross both product components without a shape error;(n_particles, n_hemispheres * (dim_hemisphere + 1));set_state(...)and directfilter_state = distributionassignment reset stale nonuniform weights to uniform.Validation
main(f196ec41d1d8681e279936db9f1a0a3abfa276e7);