Skip to content

docs: improve addCurrentTimeChangeListener method documentation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javier-godoy merged 1 commit into from
Mar 13, 2023
Merged

docs: improve addCurrentTimeChangeListener method documentation #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/com/flowingcode/vaadin/addons/simpletimer/SimpleTimer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,16 @@ public CompletableFuture<BigDecimal> getCurrentTimeAsync() {

/**
* Adds a property change listener for the {@code currentTime} property
*
* @param listener the property change listener
* @param period the minimum period between listener invocations, or 0 to disable throttling
* @param periodUnit time duration of throttling period
*
* @return current value in seconds
* @return this registration, for chaining
*/
public Registration addCurrentTimeChangeListener(
PropertyChangeListener listener, long time, TimeUnit timeUnit) {
int millis = (int) Math.min(timeUnit.toMillis(time), Integer.MAX_VALUE);
PropertyChangeListener listener, long period, TimeUnit periodUnit) {
int millis = (int) Math.min(periodUnit.toMillis(period), Integer.MAX_VALUE);
if (listener == null) {
listener = ev -> {};
}
Expand Down