Conversation
TASK: Replace removed fusion prototypes
dlubitz
changed the title
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
I tried to do a review, but I failed because I don't completely understand the desired behavior of the SortRecursiveByIndexOperation..
I leave some comments anyways, for now
| return $flip * $positionDiff < 0 ? -1 : 1; | ||
| } | ||
| // No diff in path, we need to go deeper, or they are eventually equal | ||
| $commonParentPathSegmentNodeAggregateId = $aPathSegmentNodeAggregateId; |
There was a problem hiding this comment.
Absolutely not your fault, but I find it really hard to review this. And since there are no tests, it's not easy to verify the desired behavior
There was a problem hiding this comment.
Yes, absolutly. But I can't provide that for each package, where I just want to help out to get this package compatible with Neos 9.
markusguenther
left a comment
markusguenther
left a comment
There was a problem hiding this comment.
Tested the package with docs.neos.io and another Neos instance. Cannot verify that everything is working. So @bwaidelich is right. But if something does occur, we need to fix it anyway. And when the PR is not released, the people will not find that out as they don’t use it or complain that it is incompatible.
5 participants
Provides compatibility with Neos 9.0.