add support for defmt#110
Conversation
|
That you for the PR. I'm not yet familiar with |
|
From my side I think it's a good addition. |
For more context defmt is developed under the kurling-rs project by ferrous systems. Advantages
Disadvantages/Risks
|
Sh3Rm4n
left a comment
There was a problem hiding this comment.
Ha, I made a draft for implementing defmt as well, but did not had the time to make a proper PR out of it. 😀
So I took the opportunity to look over your implantation :)
LGTM
Co-authored-by: Fabian <f.vioel@gmail.com>
|
Tests are failing. Looks like some undefined references in the |
|
It seems like only windows is failing and the linux build is successful. This might be because It might just be that defmt does not support windows. |
|
It does support Windows, just not non-embedded targets (knurling-rs/defmt#463). I am surprised the unit tests ran on Linux at all! I pushed a change to skip the defmt feature for the unit tests. |
This pull-request adds optional support for
defmt.defmt, like this crate aims to solve a problem in the core library, namely the code-size of the formatting logic.