Add scaling_factor method to FixedPoint#113
Merged
Merged
Conversation
Member
|
Thank you for the PR! There are a few great points here. First, we are fixing the need to create an object just to get the I hadn't really considered the need to multiply a rate and duration, so thank you for bringing that to my attention. You shouldn't have to get the integer values to do so. That will be rectified. In addition, #92 will likely add a required I will accept your PR shortly and target the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
duration::Genericorrate::Genericgetting the scaling factor is as easy as callingrate.scaling_factor().For examle today I tried to muliply a
Hertzvariable with aMicrosecondvariable. To do this now, needs the followingThis could also introduce subtle bugs, as the
SCALING_FACTORcall is not bound to thetimevariable.Providing a method, which just returns the value of the associated constant, allows this:
The ergonomics of the
Generictypes are quite nice, but I miss it for the other types.