Generic add/sub#90
Merged
PTaylor-us merged 4 commits intoAug 28, 2021
Merged
Conversation
Collaborator
Author
|
Ping @PTaylor-us |
Removed all use of unwrap
korken89
force-pushed
the
generic_add_sub_instant_integer
branch
3 times, most recently
from
95ff29b to
e3768b9
Compare
Collaborator
Author
|
I think this is ready for review @PTaylor-us |
korken89
force-pushed
the
generic_add_sub_instant_integer
branch
from
e3768b9 to
524be16
Compare
|
I am currently in a situation where I need exactly this functionality. How is the state of this being merged? :) |
|
Would it make sense to not only add an implementation for Instant - Generic, but also for Generic - Generic? |
Collaborator
Author
|
@jhbruhn I have added it. |
Member
|
Does it make sense to add other arithmetic for Generic as well (mult, div)? I want to target the next release for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Fixes #89