Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Preserve Sortformer tentative tail during finalize
  • Loading branch information
SGD2718 committed Mar 25, 2026
commit 898b5014fe20c5d61cdbfd94bd6b46050688878f
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,9 @@ public final class SortformerDiarizer: Diarizer {
}

var lastResult: DiarizerChunkResult?
var tentativeToFlush = _timeline.numTentativeFrames
if let chunk = try makeStreamingChunkLocked() {
tentativeToFlush = chunk.tentativeFrameCount
let finalizedChunk = DiarizerChunkResult(
startFrame: chunk.startFrame,
finalizedPredictions: chunk.finalizedPredictions,
Expand All @@ -514,7 +516,7 @@ public final class SortformerDiarizer: Diarizer {
lastResult = finalizedChunk
}

let targetEndFrame = _numFramesProcessed + min(_timeline.numTentativeFrames, config.chunkLen)
let targetEndFrame = _numFramesProcessed + min(tentativeToFlush, config.chunkLen)
let exactPaddingSamples = exactFinalizationPaddingSamples(targetEndFrame: targetEndFrame)
if exactPaddingSamples > 0 {
audioBuffer.append(contentsOf: [Float](repeating: 0, count: exactPaddingSamples))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,35 @@ final class SortformerStreamingIntegrationTests: XCTestCase {
XCTAssertEqual(finalChunk?.tentativePredictions.count, 0)
XCTAssertEqual(streamingDiarizer.timeline.numTentativeFrames, 0)
}

func testFinalizeSessionFlushesTentativeTailAfterAddAudioOnly() async throws {
let config = SortformerConfig.default
let models: SortformerModels
do {
models = try await loadModelsForTest(config: config)
} catch {
throw XCTSkip("Sortformer models unavailable in this environment: \(error)")
}
let samples = try DiarizationTestFixtures.fixtureAudio(sampleRate: config.sampleRate, limitSeconds: 4.0)

let bufferedDiarizer = SortformerDiarizer(config: config)
bufferedDiarizer.initialize(models: models)
bufferedDiarizer.addAudio(samples)
let bufferedFinalChunk = try bufferedDiarizer.finalizeSession()

let streamingDiarizer = SortformerDiarizer(config: config)
streamingDiarizer.initialize(models: models)
for chunk in DiarizationTestFixtures.chunk(samples, sizes: [4_800, 7_680, 9_600]) {
let _ = try streamingDiarizer.process(samples: chunk)
}
let _ = try streamingDiarizer.finalizeSession()

XCTAssertNotNil(bufferedFinalChunk)
XCTAssertEqual(bufferedFinalChunk?.tentativeFrameCount, 0)
XCTAssertEqual(bufferedDiarizer.timeline.numTentativeFrames, 0)
XCTAssertEqual(
bufferedDiarizer.timeline.numFinalizedFrames,
streamingDiarizer.timeline.numFinalizedFrames
)
}
}
Loading