Skip to content

Skip error recovery on intentional cancellation#481

Merged
Alex-Wengg merged 1 commit intomainfrom
claude/fix-github-failures-0RiH0
Apr 4, 2026
Merged

Skip error recovery on intentional cancellation#481
Alex-Wengg merged 1 commit intomainfrom
claude/fix-github-failures-0RiH0

Conversation

@Alex-Wengg
Copy link
Copy Markdown
Member

@Alex-Wengg Alex-Wengg commented Apr 4, 2026

Summary

  • Guard catch sites in SlidingWindowAsrManager.processWindow() and the audio buffer loop against CancellationError / Task.isCancelled
  • Prevents spurious decoder reset and model re-download when the manager is intentionally cancelled

Fixes #477

When SlidingWindowAsrManager is cancelled, CancellationError propagates
through processWindow() and the audio buffer loop. Previously this
triggered attemptErrorRecovery() which resets the decoder and, as a
last resort, re-downloads models — neither of which is appropriate for
an intentional shutdown.

Guard both catch sites with `error is CancellationError || Task.isCancelled`
to return immediately instead.

Fixes #477

https://claude.ai/code/session_01696MyMtoiM6T8ruCdCCHab
@Alex-Wengg Alex-Wengg force-pushed the claude/fix-github-failures-0RiH0 branch from c2ce33b to 6be4fd2 Compare April 4, 2026 13:27
@Alex-Wengg Alex-Wengg changed the title Add Japanese ASR support with JSUT and Common Voice datasets Skip error recovery on intentional cancellation Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Qwen3-ASR int8 Smoke Test ✅

Check Result
Build
Model download
Model load
Transcription pipeline
Decoder size 571 MB (vs 1.1 GB f32)

Performance Metrics

Metric CI Value Expected on Apple Silicon
Median RTFx 0.06x ~2.5x
Overall RTFx 0.06x ~2.5x

Runtime: 3m48s

Note: CI VM lacks physical GPU — CoreML MLState (macOS 15) KV cache produces degraded results on virtualized runners. On Apple Silicon: ~1.3% WER / 2.5x RTFx.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

✅ Japanese ASR Benchmark Results (CTC)

Status: Passed

Metric Value
CER 9.94%
Samples 50
Avg RTFx 2.3x
Decoder CTC

✅ Benchmark completed successfully. The TDT Japanese hybrid model (CTC preprocessor/encoder + TDT decoder/joint) is working correctly.

View benchmark log

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Sortformer High-Latency Benchmark Results

ES2004a Performance (30.4s latency config)

Metric Value Target Status
DER 33.4% <35%
Miss Rate 24.4% - -
False Alarm 0.2% - -
Speaker Error 8.8% - -
RTFx 10.8x >1.0x
Speakers 4/4 - -

Sortformer High-Latency • ES2004a • Runtime: 2m 23s • 2026-04-04T14:01:59.112Z

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Parakeet EOU Benchmark Results ✅

Status: Benchmark passed
Chunk Size: 320ms
Files Tested: 100/100

Performance Metrics

Metric Value Description
WER (Avg) 7.03% Average Word Error Rate
WER (Med) 4.17% Median Word Error Rate
RTFx 6.92x Real-time factor (higher = faster)
Total Audio 470.6s Total audio duration processed
Total Time 70.8s Total processing time

Streaming Metrics

Metric Value Description
Avg Chunk Time 0.071s Average chunk processing time
Max Chunk Time 0.142s Maximum chunk processing time
EOU Detections 0 Total End-of-Utterance detections

Test runtime: 1m35s • 04/04/2026, 09:57 AM EST

RTFx = Real-Time Factor (higher is better) • Processing includes: Model inference, audio preprocessing, state management, and file I/O

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Kokoro TTS Smoke Test ✅

Check Result
Build
Model download
Model load
Synthesis pipeline
Output WAV ✅ (634.8 KB)

Runtime: 0m37s

Note: Kokoro TTS uses CoreML flow matching + Vocos vocoder. CI VM lacks physical ANE — performance may differ from Apple Silicon.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

ASR Benchmark Results ⚠️

Status: Some benchmarks failed (see logs)

Parakeet v3 (multilingual)

Dataset WER Avg WER Med RTFx Status
test-clean % % x ⚠️
test-other % % x ⚠️

Parakeet v2 (English-optimized)

Dataset WER Avg WER Med RTFx Status
test-clean % % x ⚠️
test-other % % x ⚠️

Streaming (v3)

Metric Value Description
WER % Word Error Rate in streaming mode
RTFx x Streaming real-time factor
Avg Chunk Time s Average time to process each chunk
Max Chunk Time s Maximum chunk processing time
First Token s Latency to first transcription token
Total Chunks Number of chunks processed

Streaming (v2)

Metric Value Description
WER % Word Error Rate in streaming mode
RTFx x Streaming real-time factor
Avg Chunk Time s Average time to process each chunk
Max Chunk Time s Maximum chunk processing time
First Token s Latency to first transcription token
Total Chunks Number of chunks processed

Streaming tests use 5 files with 0.5s chunks to simulate real-time audio streaming

files per dataset • Test runtime: • 04/04/2026, 09:51 AM EST

RTFx = Real-Time Factor (higher is better) • Calculated as: Total audio duration ÷ Total processing time
Processing time includes: Model inference on Apple Neural Engine, audio preprocessing, state resets between files, token-to-text conversion, and file I/O
Example: RTFx of 2.0x means 10 seconds of audio processed in 5 seconds (2x faster than real-time)

Expected RTFx Performance on Physical M1 Hardware:

• M1 Mac: ~28x (clean), ~25x (other)
• CI shows ~0.5-3x due to virtualization limitations

Testing methodology follows HuggingFace Open ASR Leaderboard

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PocketTTS Smoke Test ✅

Check Result
Build
Model download
Model load
Synthesis pipeline
Output WAV ✅ (206.3 KB)

Runtime: 0m42s

Note: PocketTTS uses CoreML MLState (macOS 15) KV cache + Mimi streaming state. CI VM lacks physical GPU — audio quality may differ from Apple Silicon.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Offline VBx Pipeline Results

Speaker Diarization Performance (VBx Batch Mode)

Optimal clustering with Hungarian algorithm for maximum accuracy

Metric Value Target Status Description
DER 14.5% <20% Diarization Error Rate (lower is better)
RTFx 3.78x >1.0x Real-Time Factor (higher is faster)

Offline VBx Pipeline Timing Breakdown

Time spent in each stage of batch diarization

Stage Time (s) % Description
Model Download 12.820 4.6 Fetching diarization models
Model Compile 5.494 2.0 CoreML compilation
Audio Load 0.111 0.0 Loading audio file
Segmentation 29.059 10.5 VAD + speech detection
Embedding 276.445 99.6 Speaker embedding extraction
Clustering (VBx) 0.792 0.3 Hungarian algorithm + VBx clustering
Total 277.440 100 Full VBx pipeline

Speaker Diarization Research Comparison

Offline VBx achieves competitive accuracy with batch processing

Method DER Mode Description
FluidAudio (Offline) 14.5% VBx Batch On-device CoreML with optimal clustering
FluidAudio (Streaming) 17.7% Chunk-based First-occurrence speaker mapping
Research baseline 18-30% Various Standard dataset performance

Pipeline Details:

  • Mode: Offline VBx with Hungarian algorithm for optimal speaker-to-cluster assignment
  • Segmentation: VAD-based voice activity detection
  • Embeddings: WeSpeaker-compatible speaker embeddings
  • Clustering: PowerSet with VBx refinement
  • Accuracy: Higher than streaming due to optimal post-hoc mapping

🎯 Offline VBx Test • AMI Corpus ES2004a • 1049.0s meeting audio • 306.3s processing • Test runtime: 5m 4s • 04/04/2026, 10:04 AM EST

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Speaker Diarization Benchmark Results

Speaker Diarization Performance

Evaluating "who spoke when" detection accuracy

Metric Value Target Status Description
DER 15.1% <30% Diarization Error Rate (lower is better)
JER 24.9% <25% Jaccard Error Rate
RTFx 30.84x >1.0x Real-Time Factor (higher is faster)

Diarization Pipeline Timing Breakdown

Time spent in each stage of speaker diarization

Stage Time (s) % Description
Model Download 8.255 24.3 Fetching diarization models
Model Compile 3.538 10.4 CoreML compilation
Audio Load 0.031 0.1 Loading audio file
Segmentation 10.206 30.0 Detecting speech regions
Embedding 17.010 50.0 Extracting speaker voices
Clustering 6.804 20.0 Grouping same speakers
Total 34.029 100 Full pipeline

Speaker Diarization Research Comparison

Research baselines typically achieve 18-30% DER on standard datasets

Method DER Notes
FluidAudio 15.1% On-device CoreML
Research baseline 18-30% Standard dataset performance

Note: RTFx shown above is from GitHub Actions runner. On Apple Silicon with ANE:

  • M2 MacBook Air (2022): Runs at 150 RTFx real-time
  • Performance scales with Apple Neural Engine capabilities

🎯 Speaker Diarization Test • AMI Corpus ES2004a • 1049.0s meeting audio • 34.0s diarization time • Test runtime: 2m 3s • 04/04/2026, 09:59 AM EST

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

VAD Benchmark Results

Performance Comparison

Dataset Accuracy Precision Recall F1-Score RTFx Files
MUSAN 92.0% 86.2% 100.0% 92.6% 780.9x faster 50
VOiCES 92.0% 86.2% 100.0% 92.6% 807.6x faster 50

Dataset Details

  • MUSAN: Music, Speech, and Noise dataset - standard VAD evaluation
  • VOiCES: Voices Obscured in Complex Environmental Settings - tests robustness in real-world conditions

✅: Average F1-Score above 70%

@Alex-Wengg Alex-Wengg merged commit 1b76be6 into main Apr 4, 2026
13 of 22 checks passed
@Alex-Wengg Alex-Wengg deleted the claude/fix-github-failures-0RiH0 branch April 4, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamingAsrManager wrongly recovers on intentional shutdown cancellation

2 participants