-
Notifications
You must be signed in to change notification settings - Fork 243
feat(tts): add configurable computeUnits for Kokoro models #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Alex-Wengg
merged 4 commits into
FluidInference:main
from
IntegrIT-Solutions:feat/kokoro-configurable-compute-units
Apr 4, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
81cdff2
feat(tts): add configurable computeUnits for Kokoro TTS models
integrITsolutions 5edcba9
fix(tts): propagate computeUnits to modelCache when directory is nil
integrITsolutions 119f599
Merge branch 'main' into feat/kokoro-configurable-compute-units
integrITsolutions db66190
Merge branch 'main' into feat/kokoro-configurable-compute-units
integrITsolutions File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat(tts): add configurable computeUnits for Kokoro TTS models
Adds a `computeUnits` parameter (default: `.all`) to `TtsModels.download()`, `KokoroTtsManager.init()`, and `KokoroModelCache.init()`, allowing callers to override CoreML compute units for Kokoro model loading. This is needed because iOS 26 introduces ANE compiler regressions that cause Kokoro models to fail with "Cannot retrieve vector from IRValue format int32" when loaded with `.all` (which includes the Neural Engine). Using `.cpuAndGPU` bypasses the ANE and resolves the issue, matching the approach already used by PocketTTS to avoid ANE float16 precision artifacts. The default `.all` preserves existing behavior on iOS 17-18. Callers on iOS 26+ can pass `.cpuAndGPU` to work around the ANE regression. Example: ```swift let manager = KokoroTtsManager(computeUnits: .cpuAndGPU) try await manager.initialize() ```
- Loading branch information
commit 81cdff2ad0c733d33b129902b20bbfcb2c0ec2c1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.