docs: Clarify online vs offline diarization pipeline versions#7
Open
Alex-Wengg wants to merge 1 commit intomainfrom
Open
docs: Clarify online vs offline diarization pipeline versions#7Alex-Wengg wants to merge 1 commit intomainfrom
Alex-Wengg wants to merge 1 commit intomainfrom
Conversation
Distinguish between the two diarization pipelines: - Online/streaming (DiarizerManager): Pyannote 3.1 - Offline batch (OfflineDiarizerManager): Pyannote Community-1 Updated documentation: - mobius/getting-started.mdx: Updated model table to show both versions - diarization/streaming.mdx: Added Pyannote 3.1 reference to overview - diarization/getting-started.mdx: Added version note to Quick Start Addresses PR #6 review comment: #6 (comment)
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review comment from #6 (comment)
Clarifies the distinction between online and offline diarization pipeline versions:
DiarizerManager): Pyannote 3.1OfflineDiarizerManager): Pyannote Community-1Both use models from the same CoreML repo: https://huggingface.co/FluidInference/speaker-diarization-coreml
Changes
1. mobius/getting-started.mdx
Updated the Converted Models table to show both versions:
2. diarization/streaming.mdx
Added version info to the Overview section:
3. diarization/getting-started.mdx
Added version note to Quick Start section:
Context
PR #6 updated references from 3.1 to community-1, which was correct for the offline pipeline. However, Brandon's review clarified that both versions are correct - they just apply to different pipelines. This PR makes that distinction clear throughout the documentation.
Companion PR
A matching PR has been created in the FluidAudio repo: FluidInference/FluidAudio#511