fix: address Devin review issues in Qwen3-ForcedAligner scripts#32
Merged
Alex-Wengg merged 2 commits intomainfrom Mar 21, 2026
Merged
fix: address Devin review issues in Qwen3-ForcedAligner scripts#32Alex-Wengg merged 2 commits intomainfrom
Alex-Wengg merged 2 commits intomainfrom
Conversation
- Fix dict slicing on ref_data (use ref_data["samples"] to match compare-models.py output format) - Fix KeyError: use "transcript" key instead of "text" - Fix KeyError: use "start_time_ms"/"end_time_ms" instead of "start_ms"/"end_ms" to match compare-models.py output - Thread --no-optimize CLI flag through all _coreml_convert calls (was silently ignored before)
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #21 addressing issues flagged by Devin review.
TypeErrorfrom dict slicing:ref_data[:num_files]→ref_data["samples"][:num_files]KeyErroron sample key:sample["text"]→sample["transcript"]KeyErroron alignment keys:ref["start_ms"]/ref["end_ms"]→ref["start_time_ms"]/ref["end_time_ms"]--no-optimizeCLI flag through all 6_coreml_convert()calls (was silently ignored)Test plan
uv run python run_coreml_inference.py --compare-pytorchto verify parity comparison worksuv run python convert-coreml.py --no-optimizeto verify flag is respected