Skip to content

11 bug incorrect variable references #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bzarboni1 merged 4 commits into from
Mar 6, 2024
Merged

11 bug incorrect variable references #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79aee3b
Fixed resource name
bzarboni1 Mar 6, 2024
bb5e958
Fixed GH Actions Secrets value
bzarboni1 Mar 6, 2024
00c7e1b
Missed a variable fix
bzarboni1 Mar 6, 2024
b48c5d6
Correct previous fix
bzarboni1 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions modules/foundations-github-organization/action-variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
resource "github_actions_secret" "organization_workload_identity_sa" {
provider = github.foundation_org_scoped

repository = github_repository.organizations_repo.name
secret_name = "GCP_SERVICE_ACCOUNT"
value = var.organization_workload_identity_sa
repository = github_repository.organizations_repo.name
secret_name = "GCP_SERVICE_ACCOUNT"
plaintext_value = var.organization_workload_identity_sa
Comment thread
bzarboni1 marked this conversation as resolved.
}

resource "github_actions_variable" "gcp_secret_manager_project_id" {
Expand All @@ -17,9 +17,9 @@ resource "github_actions_variable" "gcp_secret_manager_project_id" {
resource "github_actions_organization_secret" "workload_identity_provider" {
provider = github.foundation_org_scoped

secret_name = "WORKLOAD_IDENTITY_PROVIDER"
value = var.workload_identity_provider_name
visibility = "selected"
secret_name = "WORKLOAD_IDENTITY_PROVIDER"
plaintext_value = var.workload_identity_provider_name
visibility = "selected"
selected_repository_ids = [
github_repository.bootstrap_repo.repo_id,
github_repository.organizations_repo.repo_id
Expand Down
2 changes: 1 addition & 1 deletion modules/foundations-github-organization/repo_readme.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ resource "github_repository_file" "main_readme" {
count = var.readme_path != "" ? 1 : 0
repository = github_repository.organizations_repo.name
file = "README.md"
content = data.file.main_readme.content
content = data.local_file.main_readme.content
depends_on = [github_repository.organizations_repo]
}