Added field for user permissions#35
Merged
Merged
Conversation
bzarboni1
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pr adds a field to allow giving individual users permissions to a repository. I didn't provide a default permissions property that would apply these permissions to all repositories in the repository set like we do for teams because the use case for using this field would probably be less of a blanket permission assignment but more of a precise permission assignment to a repository.
This PR also makes both permissions fields optional so repositories can be created with no explicit permissions for anyone. This would lock out everyone except users in the organization that have been given access to repositories through their organization role. Ex: organization admins. I figured this is a sane default and would allow people to bring their repositories into the toolkit incrementally by not having to make them define permissions if they don't want to.