[Bug] Advance Security Not Enabled#37
Merged
Merged
Conversation
TylerMizuyabu
previously approved these changes
Apr 3, 2024
TylerMizuyabu
previously approved these changes
Apr 3, 2024
TylerMizuyabu
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#36] - [Bug] Can't enable advanced security on public repos
ISSUE
While attempting to set the "Advanced Security" to enabled for a public repo, it was noticed that this is explicitly denied in code. The assumption stated is that public repos have already been set to have Advanced Security, but this is not the case when the Terraform had run.
Additionally
The
pre-commitchecks ran on the files changed, and requested a number of fixes, included in this PR