Adding AWS OIDC module#48
Merged
Merged
Conversation
bzarboni1
approved these changes
Jun 17, 2024
|
|
||
| variable "github_thumbprints" { | ||
| type = list(string) | ||
| description = "A list of top intermediate certifact authority thumbprints to use for setting up an openid connect provider with github. Info on how to obtain thumbprints here: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html" |
Contributor
There was a problem hiding this comment.
Suggested change
| description = "A list of top intermediate certifact authority thumbprints to use for setting up an openid connect provider with github. Info on how to obtain thumbprints here: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html" | |
| description = "A list of top intermediate certificate authority thumbprints to use for setting up an OpenID Connect provider with github. Info on how to obtain thumbprints here: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html" |
|
|
||
| variable "github_repo_owner" { | ||
| type = string | ||
| description = "The owner of the github foundations organizations repository. This value should be whatever github account you plan to make the repository under." |
Contributor
There was a problem hiding this comment.
Suggested change
| description = "The owner of the github foundations organizations repository. This value should be whatever github account you plan to make the repository under." | |
| description = "The owner of the github foundations organizations repository. This value should be the github account to make the repository under." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a module to setup oidc with AWS. The module creates the following resources: