Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

Make the changePage and scrollTo functionality accesable to the public#128

Merged
hebertialmeida merged 6 commits into
FolioReader:masterfrom
smartmobilefactory:feature/ScrollToCustomPlaces
Sep 6, 2016
Merged

Make the changePage and scrollTo functionality accesable to the public#128
hebertialmeida merged 6 commits into
FolioReader:masterfrom
smartmobilefactory:feature/ScrollToCustomPlaces

Conversation

@tschob
Copy link
Copy Markdown
Member

@tschob tschob commented Sep 2, 2016

Following changes are made to provide the ability to scroll to anchors from outside of the FolioReaderKit:

  • make the FolioReaderPage class public
  • Add a public getter for the FolioReaderCenter to the FolioReaderContainer
  • Add a public getter for the current FolioReaderPage to the FolioReaderCenter

@tschob tschob changed the title Make the changePage and scrollTo functionaility accesable to the public Make the changePage and scrollTo functionality accesable to the public Sep 2, 2016

// MARK: Public page methods

public func changePageWith(page page: Int, animated: Bool = false, completion: (() -> Void)? = nil) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some docs for public functions, so you help me on generated docs 😀

@tschob
Copy link
Copy Markdown
Member Author

tschob commented Sep 5, 2016

@hebertialmeida I have update my PR based on your comments.

@hebertialmeida hebertialmeida merged commit cc28afa into FolioReader:master Sep 6, 2016
@tschob tschob deleted the feature/ScrollToCustomPlaces branch September 16, 2016 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants