Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

If navbar doesn't hide on tap, it should not hide when font menu is shown#19

Closed
kjantzer wants to merge 1 commit into
FolioReader:masterfrom
kjantzer:fix/19
Closed

If navbar doesn't hide on tap, it should not hide when font menu is shown#19
kjantzer wants to merge 1 commit into
FolioReader:masterfrom
kjantzer:fix/19

Conversation

@kjantzer
Copy link
Copy Markdown
Member

@kjantzer kjantzer commented Jan 6, 2016

No description provided.

@hebertialmeida
Copy link
Copy Markdown
Member

I have to hide it because of the day/night transition effect, it looks strange with the navigationBar.

@kjantzer
Copy link
Copy Markdown
Member Author

kjantzer commented Jan 6, 2016

I wondered if that may have been why you did that.

I added FolioReader.sharedInstance.readerCenter.configureNavBar() to help this, although its not perfect because it does not animate the color change.

daynight mov

@hebertialmeida
Copy link
Copy Markdown
Member

Yes, the animation is not smooth, so I prefer to hide. What do you think?

@kjantzer
Copy link
Copy Markdown
Member Author

kjantzer commented Jan 6, 2016

I really wish we could animate the navbar, but in my limited research, I did not find a way to animate navBar?.setBackgroundImage()

We can keep it hidden for now. The reason I changed it was because the hideBar() is being called when presenting the "audio controls" view and it looked weird to have the navbar hide itself. When I traced it out, I noticed it happening in the font menu view so I changed it for both.

I'll keep the navbar visible for the audio controls view only.

@hebertialmeida
Copy link
Copy Markdown
Member

So I don't think I need merge this for now right?

@kjantzer
Copy link
Copy Markdown
Member Author

kjantzer commented Jan 7, 2016

Correct.

@kjantzer kjantzer deleted the fix/19 branch January 13, 2016 23:34
@hebertialmeida hebertialmeida self-assigned this Sep 21, 2016
tschob added a commit that referenced this pull request May 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants