Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

Better support for iPhone X and NightMode Fix#270

Closed
mgiroux wants to merge 4 commits into
FolioReader:masterfrom
mgiroux:master
Closed

Better support for iPhone X and NightMode Fix#270
mgiroux wants to merge 4 commits into
FolioReader:masterfrom
mgiroux:master

Conversation

@mgiroux
Copy link
Copy Markdown

@mgiroux mgiroux commented Oct 11, 2017

Adds support for iPhone X regarding the PageIndicator (was hidden by the swipe home bar)
Fixes night mode glitch (white pages / white borders on pages)

Support the little "swipe up to go home" bar on new iPhone X (relies on screen height that is specific to iphone x)
@hebertialmeida hebertialmeida self-assigned this Oct 12, 2017
@hebertialmeida
Copy link
Copy Markdown
Member

hebertialmeida commented Oct 12, 2017

Hi @mgiroux, thanks for your contribution!

I think this needs a little bit more work, I have tested it and it initially fixes the problem with iPhone X in portrait mode, but for landscape, it is not working even for the normal iPhone.

I found this iPhone X guidelines (https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/), I think the path is to try to implement this "safe area", so it will work with any device, on any orientation.

This is how it looks like:
screen shot 2017-10-11 at 10 04 05 pm
screen shot 2017-10-11 at 10 06 01 pm

What do you think?

@hebertialmeida
Copy link
Copy Markdown
Member

This is also related to #261

@mgiroux
Copy link
Copy Markdown
Author

mgiroux commented Oct 12, 2017

I agree that i did not look passed the portrait on iphone (cause really who reads in landscape on iphone) but i could implement the changes for that. As far as the text goes, i would have to look around and figure out where you position the view so i can fix it for iphone x. Let me know

@mgiroux
Copy link
Copy Markdown
Author

mgiroux commented Oct 12, 2017

i have implemented the fix for landscape iphone x

screen shot 2017-10-12 at 10 17 02 am
screen shot 2017-10-12 at 10 17 34 am

screen shot 2017-10-12 at 10 16 17 am
screen shot 2017-10-12 at 10 16 24 am

(iPhone 8+)

it lines up with the navigation bar.

I commited the changes.

Also, i tried to place the reader page, but it does not like to be moved the way i did it (it would mess up page alignment and would skip full chapter when rotating back to portrait)... i might leave this one to you.

Thanks

@hebertialmeida
Copy link
Copy Markdown
Member

Hey @mgiroux, looks like #287 have covered the Swift 4 migration and iPhone X, I have merged that and I will close this for one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants