Better support for iPhone X and NightMode Fix#270
Conversation
Support the little "swipe up to go home" bar on new iPhone X (relies on screen height that is specific to iphone x)
|
Hi @mgiroux, thanks for your contribution! I think this needs a little bit more work, I have tested it and it initially fixes the problem with iPhone X in portrait mode, but for landscape, it is not working even for the normal iPhone. I found this iPhone X guidelines (https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/), I think the path is to try to implement this "safe area", so it will work with any device, on any orientation. What do you think? |
|
This is also related to #261 |
|
I agree that i did not look passed the portrait on iphone (cause really who reads in landscape on iphone) but i could implement the changes for that. As far as the text goes, i would have to look around and figure out where you position the view so i can fix it for iphone x. Let me know |
|
i have implemented the fix for landscape iphone x (iPhone 8+) it lines up with the navigation bar. I commited the changes. Also, i tried to place the reader page, but it does not like to be moved the way i did it (it would mess up page alignment and would skip full chapter when rotating back to portrait)... i might leave this one to you. Thanks |






Adds support for iPhone X regarding the PageIndicator (was hidden by the swipe home bar)
Fixes night mode glitch (white pages / white borders on pages)