Skip to content

Fix React dependency to enable XCode 12 build#562

Merged
jpdriver merged 1 commit into
FormidableLabs:mainfrom
harunsmrkovic:patch-1
Sep 24, 2020
Merged

Fix React dependency to enable XCode 12 build#562
jpdriver merged 1 commit into
FormidableLabs:mainfrom
harunsmrkovic:patch-1

Conversation

@harunsmrkovic

Copy link
Copy Markdown
Contributor

Fixes react/react-native#29633 (comment)

Description

Check linked Issue, it describes the faulty dependency.

Steps to verify

@jpdriver jpdriver self-requested a review September 24, 2020 06:11
@jpdriver

Copy link
Copy Markdown
Contributor

hey @harunsmrkovic -- thanks for picking this up!

both the Example app and a completely fresh RN 62.3 app build fine for me either with or without this change (Xcode 12A7209) so to that end I think we should merge this in but I don't think there's a huge need for it to be released immediately just yet?

let me know if this is actually causing a build issue for you, or if you're just being a good Open Source citizen 😄

cheers

@jpdriver jpdriver merged commit d5fc095 into FormidableLabs:main Sep 24, 2020
@harunsmrkovic

Copy link
Copy Markdown
Contributor Author

Hey @jpdriver, thanks for the quick merge! yeah, actually lack of this PR is causing a build issue for me, but I'm getting it for a ton of other dependencies as well, so I needed to resort to patch-package anyway.

In that context, I don't think that release is urgent, as anyone experiencing this issue will have to resolve it manually anyway 🙃

@harunsmrkovic harunsmrkovic deleted the patch-1 branch September 24, 2020 09:06
@Guuz

Guuz commented Oct 5, 2020

Copy link
Copy Markdown

I'm running into this issue too. And react-native-app-auth seems to be (one of) the last package for my project to have not fixed/released this yet. So a release would be welcome! @jpdriver @harunsmrkovic

@jpdriver

jpdriver commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

@harunsmrkovic @Guuz this has finally gone out in v6.0.2 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to build using Xcode 12 Beta 4

3 participants